Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extraData parameter to info function #762

Merged

Conversation

hurali97
Copy link
Contributor

@hurali97 hurali97 commented Jul 24, 2024

Fixed Issues

$ Expensify/App#45275

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    • Adjusted Logger-test.js to test for extraData argument
  2. What tests did you perform that validates your changed worked?
    • Applied the changes locally to this PR. The extraData parameter will not be printed in the Debug Console and it's only exported to the logs file.

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

Following are the steps from the linked PR, which can be followed by the QA for testing.

Testing:

  • Run the app on environment other than Dev
  • Enable Client side logging
  • Close the App and re launch it
  • Click on View debug console in Settings-> Trouble Shoot
  • Click on the three dot menu
  • Filter the logs to Network
  • You should only see logs with Network keyword
  • Download the network only logs
  • Change the extension to .json and open in any editor
  • Verify that the output is readable and contains request and response data for API related logs

You can also follow the video:

Video
logs.mp4

Copy link

github-actions bot commented Jul 24, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@hurali97
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hurali97 hurali97 marked this pull request as ready for review July 26, 2024 12:48
@hurali97 hurali97 requested a review from a team as a code owner July 26, 2024 12:48
@melvin-bot melvin-bot bot requested review from pecanoro and removed request for a team July 26, 2024 12:49
@pecanoro pecanoro requested a review from puneetlath July 26, 2024 15:27
@puneetlath puneetlath merged commit 720929d into Expensify:main Jul 29, 2024
6 checks passed
Copy link

🚀Published to npm in v2.0.60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants