Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Remove sms domain in htmlToText #793

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix - Remove sms domain in htmlToText #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff03d1
remove sms domain in htmlToText
FitseTLT Aug 26, 2024
5d46366
updated test
FitseTLT Aug 26, 2024
3ef44c7
remove extra line
FitseTLT Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions __tests__/ExpensiMark-HTMLToText-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ test('Mention user html to text', () => {

testString = '<mention-user accountID="1234" />';
expect(parser.htmlToText(testString, extras)).toBe('@user@domain.com');

extras.accountIDToName['1234'] = '+251924892738@expensify.sms';
testString = '<mention-user accountID="1234"/>';
expect(parser.htmlToText(testString, extras)).toBe('@+251924892738');
});

test('Mention report html to text', () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/ExpensiMark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ export default class ExpensiMark {
ExpensiMark.Log.alert('[ExpensiMark] Missing account name', {accountID: g1});
return '@Hidden';
}
return `@${extras.accountIDToName?.[g1]}`;
return `@${Str.removeSMSDomain(extras.accountIDToName?.[g1] ?? '')}`;
},
},
{
Expand Down
Loading