Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use specific lodash imports #798

Merged
merged 1 commit into from
Sep 16, 2024
Merged

perf: use specific lodash imports #798

merged 1 commit into from
Sep 16, 2024

Conversation

hurali97
Copy link
Contributor

@hurali97 hurali97 commented Sep 12, 2024 •
edited
Loading

Fixed Issues

$ Expensify/App#48978

As for the testing steps, since the changes are just updated imports, they don't introduce anything new in the codebase. For the testing, I tested this code in Expensify App and nothing breaks. For the context, this PR is part of Expensify/App#49059

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@hurali97 hurali97 marked this pull request as ready for review September 13, 2024 10:50
@hurali97 hurali97 requested a review from a team as a code owner September 13, 2024 10:50
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team September 13, 2024 10:50
@deetergp deetergp merged commit 3fd82e6 into Expensify:main Sep 16, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🚀Published to npm in v2.0.89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hurali97 @deetergp