Use NSTextStorageDelegate instead of method swizzling

[tomekzaw]

Details

Work in progress.

This PR is supposed to fix these issues:

• Spellcheck for previous words gets removed while typing on iOS #34
• Use ISA swizzling instead of method swizzling on iOS #102
• Migrate away from TextKit 1 to TextKit 2 #145
• Backticks are not removed when entering diacritics using option key commands on iOS #181
• Migrate from NSRange to UITextRange on iOS #191
• No formatting after toggling multiline prop #309
• Cannot select single words on first attempt in text with headings or blockquotes on iOS #417
• Can't input some other language, such as Chinese #452
• Font size doesn't change immediately when updating styles on iOS #540

Related Issues

GH_LINK

Manual Tests

Linked PRs

[tomekzaw]

Regression: Cursor is shifted to the right when adding a newline after a blockquote

Screen.Recording.2024-10-17.at.11.38.34.mov

[tomekzaw]

Bug: spellcheck completely disappears when adding Markdown syntax

Screen.Recording.2024-10-21.at.20.50.18.mov

[tomekzaw]

Regression: Emojis are not visible

edit: [attributedString addAttributes:defaultTextAttributes range:fullRange]; breaks emoji font

edit2: fixed in 67968ec and explained better in 6e40703

[tomekzaw]

Regression: toggling text color doesn't work (it only works when you toggle markdownStyle first)

edit: it works if text doesn't contain any emojis

edit2: fixed in d377043 and explained better in 6e40703

[289Adam289]

BUG iOS:
#34 still reproducible on E/App. Behavior is a bit different. Spellcheck disappears immediately.

Screen.Recording.2024-12-13.at.15.58.02.mov

[289Adam289]

BUG iOS:

• Block quote ribbon size changes
• Block quote jumps after new line character

Screen.Recording.2024-12-13.at.16.00.37.mov

[289Adam289]

BUG iOS:
Typing fast and hitting enter causes input jumping. Bug does not occur when there is delay between typing last character and hitting enter.

Screen.Recording.2024-12-13.at.16.32.49.mov

[tomekzaw]

#520 (comment) should be fixed with b503121.

[tomekzaw]

#520 (comment) is most likely caused by UI/JS thread jump lag, it gets worse if you add sleep(500); inside App component during its render.

[tomekzaw]

As for #520 (comment), I confirm that spellcheck is broken if there's some Markdown syntax but for plain strings this should work correctly. I wasn't able to reproduce this:

Screen.Recording.2024-12-16.at.13.03.20.mov