Fix blockquote line height on iOS

[tomekzaw]

Details

This PR fixes line height inside blockquote on iOS.

When lineHeight style is set on MarkdownTextInput, React Native adds NSParagraphStyle with minimumLineHeight and maximumLineHeight to the attributed string.

In Live Markdown, blockquote indent is set using another NSParagraphStyle with firstLineHeadIndent and headIndent.

Currently, we create NSParagraphStyle using [NSParagraphStyle new], ignoring the NSParagraphStyle created by React Native.

This PR uses the NSParagraphStyle set by React Native when creating NSParagraphStyle for blockquotes.

Before	After
Screen.Recording.2024-12-16.at.12.11.27.mov	Screen.Recording.2024-12-16.at.12.10.45.mov

Related Issues

GH_LINK

Manual Tests

When testing, please set lineHeight: 30 inside styles.input in App.tsx.

Linked PRs

[tomekzaw]

Waiting for @289Adam289's review

[289Adam289]

BUG example app iOS:

Toggle text font size button does not actually change size.

Screen.Recording.2024-12-16.at.15.12.45.mov

[tomekzaw]

@289Adam289 As for #587 (comment), this is not a regression since it also happens on current main (8b1789a):

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-18.at.14.03.19.mp4

[tomekzaw]

@289Adam289 I've narrowed down the root cause of this issue to those lines:

react-native-live-markdown/apple/RCTTextInputComponentView+Markdown.mm

Lines 56 to 63 in f165434

	// Emoji characters are automatically assigned an AppleColorEmoji NSFont and the original font is moved to NSOriginalFont
	// We need to remove these attributes before comparison
	NSMutableAttributedString *newTextCopy = [newText mutableCopy];
	NSMutableAttributedString *oldTextCopy = [oldText mutableCopy];
	[newTextCopy removeAttribute:@"NSFont" range:NSMakeRange(0, newTextCopy.length)];
	[oldTextCopy removeAttribute:@"NSFont" range:NSMakeRange(0, oldTextCopy.length)];
	[oldTextCopy removeAttribute:@"NSOriginalFont" range:NSMakeRange(0, oldTextCopy.length)];
	return [newTextCopy isEqualToAttributedString:oldTextCopy];

This logic was added in #416.

When I remove these two lines, it works correctly:

-    [newTextCopy removeAttribute:@"NSFont" range:NSMakeRange(0, newTextCopy.length)];
-    [oldTextCopy removeAttribute:@"NSFont" range:NSMakeRange(0, oldTextCopy.length)];

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-18.at.14.44.43.mp4

[289Adam289]

I've checked #587 (comment) on main and indeed it is not a regression. I will test this pr on E/App and if everything goes well I think we can merge it.

[289Adam289]

I've tested this pr on E/App and I could not find any regressions. We can safely merge.

[tomekzaw]

Fixed baseline offset jumps when adding heading in fc1d1e9

Before	After
Screen.Recording.2024-12-21.at.16.20.41.mov	Screen.Recording.2024-12-21.at.16.19.50.mov

[j-piasecki]

🫣

[tomekzaw]

Some video recordings from E/App with visible improvements:

Before	After
Screen.Recording.2024-12-21.at.19.41.55.mov	Screen.Recording.2024-12-21.at.19.40.54.mov

[os-botify]

🚀 Published to npm in 0.1.211 🎉