Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Onyx.update() return a promise #206

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Make Onyx.update() return a promise #206

merged 2 commits into from
Oct 28, 2022

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 27, 2022 •
edited
Loading

Details

  • Returns a promise from Onyx.update()
  • Adds a test to verify the behavior works
  • Update some test variables that have incorrectly formatted collection keys

Related Issues

#205

Automated Tests

👍

Linked PRs

Will be added in Expensify/App#12169

@marcaaron marcaaron self-assigned this Oct 27, 2022
@marcaaron marcaaron requested a review from a team as a code owner October 27, 2022 21:37
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team October 27, 2022 21:38
@arosiclair arosiclair merged commit d3dfe61 into main Oct 28, 2022
@christianwen christianwen mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arosiclair arosiclair arosiclair approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcaaron @arosiclair