Clear cache in Onyx.clear()

[roryabraham]

Details

We recently updated Onyx.clear such that it actually removes items we don't want to keep from storage, rather than just setting them to null.

However, we did not update Onyx.clear() to update the cache accordingly – it still just sets items to null. I think this is expected for any existing Onyx subscribers – the value should go from being whatever it was before to null. However, any new call to Onyx.connect should not have any record of cleared keys.

cc @tienifr

Related Issues

https://github.com/Expensify/Expensify/issues/277227 – related to tests

Automated Tests

I was testing this in Expensify/App#17718 – there are currently some TODOs above code that filters out null items from Onyx because they're making it harder to make assertions about things like the number of reports in Onyx.

After updating Onyx to use the latest version which includes the new version of Onyx.clear and removing the filters, I found that the test was still failing and showed reports that should have been cleared as null in Onyx. After debugging, I discovered that the problem was that the cache was not being updated correctly.

I also updated the tests in this repo accordingly, and I think that the new behavior is correct.

Linked PRs

Expensify/App#17718

[roryabraham]

Edit: We were updating the cache to null, and that's kind of necessary to inform the subscribers that the data has dropped. Need to think about this some more

[chiragsalian]

lgtm

[melvin-bot]

@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[chiragsalian]

Tests were passing just fine.