Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #269] use cached data #280

Merged
merged 44 commits into from
Jul 27, 2023
Merged

[Fix #269] use cached data #280

merged 44 commits into from
Jul 27, 2023

Commits on Jul 14, 2023

  1. Use cache when wrapping a component with onyx

    @hannojg
    hannojg committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    1998ca0 View commit details
    Browse the repository at this point in the history

  2. tests: removed now unnecessary waitForPromiseToResolve calls

    @hannojg
    hannojg committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    09b9494 View commit details
    Browse the repository at this point in the history

  3. wip: one approach to solve prop updates

    @hannojg
    hannojg committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0f5e115 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. fix test

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    98a1672 View commit details
    Browse the repository at this point in the history

  2. remove componentDidUpdate code

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    916b9b0 View commit details
    Browse the repository at this point in the history

  3. add jsdoc

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    35becc3 View commit details
    Browse the repository at this point in the history

  4. clean

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4b7f267 View commit details
    Browse the repository at this point in the history

  5. fix eslint

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6943d36 View commit details
    Browse the repository at this point in the history

  6. use cache.getAllKeys directly

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    790def1 View commit details
    Browse the repository at this point in the history

  7. add better comment

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f71294e View commit details
    Browse the repository at this point in the history

  8. foeward default value eventually to selector

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9358b41 View commit details
    Browse the repository at this point in the history

  9. return early

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3ee9294 View commit details
    Browse the repository at this point in the history

  10. remove ambigous comment

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fcc49ac View commit details
    Browse the repository at this point in the history

  11. reverted back cleanups

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    853390e View commit details
    Browse the repository at this point in the history

  12. fix: selector not getting applied to collection

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0c72be1 View commit details
    Browse the repository at this point in the history

  13. fix tests

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    294aa31 View commit details
    Browse the repository at this point in the history

  14. remove unused function

    @hannojg
    hannojg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d2a5390 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Update lib/Onyx.js 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @hannojg @marcaaron
    hannojg and marcaaron authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5b00715 View commit details
    Browse the repository at this point in the history

  2. Update lib/Onyx.js 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @hannojg @marcaaron
    hannojg and marcaaron authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8a3bc95 View commit details
    Browse the repository at this point in the history

  3. simplify cached state usement

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    bf48eb3 View commit details
    Browse the repository at this point in the history

  4. remove reundand code

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fbc16fc View commit details
    Browse the repository at this point in the history

  5. avoid too many deepEqual calls

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    48570e8 View commit details
    Browse the repository at this point in the history

  6. remove other perf fix

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    68c3d04 View commit details
    Browse the repository at this point in the history

  7. clean

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    937c3f7 View commit details
    Browse the repository at this point in the history

  8. remove all premature deepEquals

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    cb505e3 View commit details
    Browse the repository at this point in the history

  9. simplify

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    46f73e1 View commit details
    Browse the repository at this point in the history

  10. remove checks in onyx for prev state as its withOnyxInstance responsi… 

    …bility to check for that
    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    a2e20d0 View commit details
    Browse the repository at this point in the history

  11. fix too many state updates

    @hannojg
    hannojg committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    617ff64 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. remove comments and todos

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5ffdefa View commit details
    Browse the repository at this point in the history

  2. manually update the loading state

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2c45edb View commit details
    Browse the repository at this point in the history

  3. add condition to check for cache usage

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d479c12 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:margelo/react-native-onyx into perf… 

    …/fix-269-use-cached-data
    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    020ccb2 View commit details
    Browse the repository at this point in the history

  5. remove now obsolete eslint warnings

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0756a27 View commit details
    Browse the repository at this point in the history

  6. Update tests/unit/withOnyxTest.js 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @hannojg @mountiny
    hannojg and mountiny authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7904d58 View commit details
    Browse the repository at this point in the history

  7. fix lint

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c7ac445 View commit details
    Browse the repository at this point in the history

  8. Update lib/withOnyx.js 

    Co-authored-by: Tim Golen <tgolen@gmail.com>
    @hannojg @tgolen
    hannojg and tgolen authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    127f56c View commit details
    Browse the repository at this point in the history

  9. Update lib/Onyx.js 

    Co-authored-by: Tim Golen <tgolen@gmail.com>
    @hannojg @tgolen
    hannojg and tgolen authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9a4135f View commit details
    Browse the repository at this point in the history

  10. Update lib/withOnyx.js 

    Co-authored-by: Tim Golen <tgolen@gmail.com>
    @hannojg @tgolen
    hannojg and tgolen authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9a41243 View commit details
    Browse the repository at this point in the history

  11. use reduce

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    cdb9e82 View commit details
    Browse the repository at this point in the history

  12. fix documentation

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1caf3f9 View commit details
    Browse the repository at this point in the history

  13. update documentation

    @hannojg
    hannojg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ad4758d View commit details
    Browse the repository at this point in the history

  14. Update lib/withOnyx.js 

    Co-authored-by: Tim Golen <tgolen@gmail.com>
    @hannojg @tgolen
    hannojg and tgolen authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e531270 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Update lib/Onyx.js 

    Co-authored-by: Carlos Martins <luacmartins@gmail.com>
    @hannojg @luacmartins
    hannojg and luacmartins authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    69fac60 View commit details
    Browse the repository at this point in the history

  2. Use cache directly without falling back to default state

    @hannojg
    hannojg committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ff82a94 View commit details
    Browse the repository at this point in the history