fix: cannot find module remotedev in production environment #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
youssef-lr
and removed request for
a team
59 tasks
|
@ospfranco has been testing if the tests are fixed after this PR |
mountiny
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Thanks, Oscar confirmed this works here Expensify/App#27130 (comment)
|
Just tested this trying to start the app with metro running and got the same error. Seems on Metro NODE_ENV is indeed set to 
@pac-guerreiro did you try running the app and not just the tests with your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When building react native onyx for
production,nodewill throw an error saying that it cannot findremotedevmodule. This is due to the fact thatremotedevis adevDependencywhich is not included inproductionbundle. To solve this,remotedevneeds to be dynamically imported.Related Issues
Expensify/App#27130 (comment)
Automated Tests
Linked PRs