Batch initial hydration. #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently opened a pull-request with feature that is batching all setStates called on withOnyx components.
All but the ones caused by connecting withOnyx to date for the first time.
It may seem to be not a big deal as we probably don't have much withOnyx components on a single screen.
Unfortunately, that's not true. All Chat items on the ReportScreen are wrapped in withOnyx.
reactionsandIOUreportprops are almost never in the cache what basically means we have to delay rendering of an item until we get those from our DB. That means that all messages are rendered in a separate renders :0We already handled the case with adding initial value pr but I'm sure similar problems occurs in other parts of the app.
This pull-requests adds logic that will batch such setStates automatically.
Details
Related Issues
GH_LINK
Automated Tests
Linked PRs