Make remove key O(log N) instead of O(N^2) #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
Beamanator
and removed request for
a team
mountiny
approved these changes
Sep 22, 2023
danieldoglas
approved these changes
Sep 22, 2023
tgolen
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I profiled app start with account provided by @danieldoglas. Turned out that remove key from cache takes O(n^2) where n is number of keys we have in cache which is set to 10k. The reason for that is that
_.difference(storageKeys, recentlyAccessed);is quadratic. It calls filter method and pass there lambda that calls contains.https://github.com/jashkenas/underscore/blob/d12221366eacbb63e37cff328bed475f34ebe083/modules/difference.js#L8
Instead we now make use of BTS structure which set is and nice property that we can access first element in O(log n) time.
Before ^
After ^
Details
Related Issues
GH_LINK
Automated Tests
Linked PRs