Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDBKeyVal get returning undefined instead of null #408

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fix IDBKeyVal get returning undefined instead of null #408

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
462f8d7
Fix IDBKeyVal get returning undefined instead of null
janicduplessis Oct 28, 2023
6854136
Update check and add comment
janicduplessis Oct 30, 2023
c092db9
Fix lint
janicduplessis Oct 30, 2023
6f77ac9
Update lib/storage/providers/IDBKeyVal.js
janicduplessis Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/storage/providers/IDBKeyVal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ const provider = {
* @param {String} key
* @return {Promise<*>}
*/
getItem: key => get(key, getCustomStore()),
getItem: key => get(key, getCustomStore())

// idb-keyval returns undefined for missing items, but this needs to return null.
janicduplessis marked this conversation as resolved.
Show resolved Hide resolved
.then(val => (val === undefined ? null : val)),

/**
* Remove given key and it's value from storage
Expand Down
Loading