Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onyx.printMetrics format #89

Merged
merged 7 commits into from
Jul 16, 2021

Commits on Jul 14, 2021

  1. Configuration menu
    Copy the full SHA
    a06856e View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Remove top level averageTime

    This doesn't represent accurate or useful information
    It was just the total time divided by the count
    of decorated methods
    kidroca committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e8413b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fae00c View commit details
    Browse the repository at this point in the history
  3. Add an override parameter to print raw times

    For example copying the raw data to excel
    allow for easier formatting sorting and
    other math operations
    kidroca committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    9a1e475 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d15c407 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Configuration menu
    Copy the full SHA
    897ba8b View commit details
    Browse the repository at this point in the history
  2. fix: method start/end are listed as 8468.7min

    This does not happen while debugging with Chrome, which is what I used
    for the most of the time and never noticed the issue
    
    Since the update for Reanimated 2 (TurboModules/JSI)
    It's no longer possible to use the old (Chrome) debugging flow
    I've discovered the timing information was not at all relative to
    app launch, the duration between start/end is correct but the
    start/end values are otherwise useless if they display like 8468.7min
    To be useful they need to be relative to app launch time
    
    Since timing otherwise works correct, we can capture an offset - APP_LAUNCH_TIME
    and subtract this value from the timings we make to capture a correct
    start/end time relative to APP_LAUNCH_TIME
    kidroca committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    541279a View commit details
    Browse the repository at this point in the history