Fix: [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event #24
Conversation
|
@thesahindia This one is ready for review! |
| @@ -0,0 +1,22 @@ | |||
| /** | |||
| * Allows us to identify whether the browser supports passive event listener. | |||
| * Because older browsers will interpret any object in the 3rd argument of an event listener as capture=true. | |||
There was a problem hiding this comment.
NAB: Don't think this line is necessary
| * Because older browsers will interpret any object in the 3rd argument of an event listener as capture=true. |
|
@thesahindia bump. |
@tienifr, can you help me with the steps that I need to get the warning? I am not getting it. Was there any specific step? |
|
@thesahindia @tienifr can we raise the PR upstream and apply the patch? it will be helpful since this fork is likely to be removed. |
|
@getusha Thanks a lot! Can you give us the context on the removal of this fork? @thesahindia What's your opinion? |
|
@tienifr we will be using |
That makes sense to me! |
Details
Fixed Issues
$ Expensify/App#26990
PROPOSAL: Expensify/App#26990 (comment)
Tests
[Violation] Added non-passive event listener to a scroll-blocking 'wheel' eventdoes not appear in the JS consoleScreenshots/Videos
Web
wheel-compressed.mov