[iOS] fix: reduce cursor size for multiline(TextInput) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
alex-mechler
approved these changes
Mar 23, 2023
alex-mechler
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
@soumyajit4419 Can you change the base branch of this from main to v0.71.2-alpha.3
alex-mechler
suggested changes
Mar 23, 2023
soumyajit4419
force-pushed
the
ios-cursor-height
branch
from
964d99c to
23b14ed
Compare
|
@alex-mechler I have changed the base branch |
|
Holding off on this since there was another regression found, and thus this was reverted in the base RN |
|
Going to close this out since we have reopened the issue for proposals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR Link
Upstream PR
Summary
Issue #15640
In Chat - Cursor in the second and following lines touches the symbols of the previous line
Changelog
[iOS] [Fixed] - Fix cursor height in RCTUITextView
Test Plan
The new UI after the code changes.
https://user-images.githubusercontent.com/46092576/226199938-78400fe7-1f25-4522-8ab9-b312c1197d5b.mov