This repository has been archived by the owner on May 23, 2024. It is now read-only.
Update knowledge sources #638
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
force-pushed
the
generate-test-data
branch
from
80d963f to
452709d
Compare
gaurav
force-pushed
the
update-knowledge-sources
branch
from
bfe53ef to
c294136
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since every Translator KP is expected to return a primary knowledge source, this PR changes the current original_knowledge_source with the new field primary_knowledge_source. We will eventually need to do a better job of figuring out exactly where non-CAM KPs come from (see e.g. #485, #494), but this should be a mostly-correct quick-and-dirty fix for now.
Closes #628.
Should be merged after PR #620.