Better handling of flashed home-wifi credentials #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkendall64
force-pushed
the
better-home-wifi
branch
from
421f893
to
7e1d995
Compare
wvarty
reviewed
Mar 1, 2022
wvarty
reviewed
Mar 1, 2022
wvarty
reviewed
Mar 1, 2022
wvarty
reviewed
Mar 1, 2022
wvarty
reviewed
Mar 1, 2022
wvarty
reviewed
Mar 1, 2022
wvarty
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the home-wifi connection handling when using flashed "home network" credentials.
If theres are flashed home-network credentials then those are used. If connection fails it then starts the access point.
On the web UI, you can select a network to connect to and this is not saved, but used temporarily (until forgotten or rebooted) e.g. if at a friends house.
If no home-network credentials are flashed then the eeprom is checked for credentials and those are used. If none are present then an access point is started. On the web UI, you can select a network to connect to and this is saved to eeprom and will be connected to and also used on subsequent reboots unless told to forget.
If this is acceptable then I'll port back to main firmware, as I think it makes a lot more sense the current behaviour.