Add extra check for 2RSS to better work with true diversity receivers #6
Conversation
|
Oh nice catch! However, rather than checking two values, I've changed it to key off TPWR. Can you check to see if the current |
Keying off from TPWR is a great idea!! Makes it simpler and more robust indeed! I have tested on the bench the file from the main branch and it worked just fine! I tested both with the EP1 Dual's and some non-diversity Rx's as well. |
|
Awesome! Thanks for testing it out and also for noticing this bug, appreciate the contribution. I'll throw up a new version a little later with the fix. |
You're welcome!! Glad to help and contribute! |
|
Now available in Release v5! |
True diversity receivers only have one "side" active at a time, so they report either 1RSS or 2RSS, with the other being 0, specially at startup. If, during startup, only 2RSS is active and reported, the widget doesn't recognize the Rx connection and keeps displaying the "No RX connected" message until 1RSS become active, which depending on the Rx environment, can take a while (it will usually only be activated once the RF link strength on the 2RSS "side" falls significantly). But since the 2RSS "side" is working properly, the Rx IS connected and working normally, so the widget can be misleading. This is the behavior I experienced with two distinct Happymodel EP1 Dual TCXO's.
This change aims to fix that, by checking that both 1RSS and 2RSS are zero (or nil) before considering as no RX connected. If either of them (or both) is non-zero (i.e. active), it considers as a normal connection.
I have tested with both EP1 Duals and some other non-diversity Rx's and it seems to work properly, but further testing is more than welcome.