Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix(Haptics): allow AudioSourceHapticPulser be placed on other object #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fight4dream
Copy link
Contributor

The pulser uses OnAudioFilterRead, it has to be placed right beneath the audio source.
But the way it is presented in the inpsector deceived us to think it can be placed elsewhere.
This fix allows it to be placed on other object.
Also fixed not getting pulse due to frame lag behind audio thread too much.

@fight4dream
Copy link
Contributor Author

#460

@fight4dream fight4dream changed the title fix(Haptics): allow AudioSourceHapticPulser be placed on other object WIP: fix(Haptics): allow AudioSourceHapticPulser be placed on other object Nov 1, 2019
The pulser uses OnAudioFilterRead, it has to be placed right beneath the audio source.
But the way it is presented in the inpsector deceived us to think it can be placed elsewhere.
This fix allows it to be placed on other object.
Also fixed not getting pulse due to frame lag behind audio thread too much.
@fight4dream
Copy link
Contributor Author

i've used this implicit version in a project and discovered that, if i would like to have both left/right hand haptics on the same audio source, they each will add their copy of observer component to the audio source. whereas the explicit version, we only need one copy of observer, and it can be shared to both hand haptics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant