Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SourceLink for easier debugging #225

Closed
MagicAndre1981 opened this issue Nov 23, 2018 · 9 comments
Closed

Enable SourceLink for easier debugging #225

MagicAndre1981 opened this issue Nov 23, 2018 · 9 comments
Assignees
Labels
developer experience Impacts how developers are using this product enhancement (cc: feat) New feature or request
Milestone

Comments

@MagicAndre1981
Copy link

Expected behavior

Press F11 to step into code and debug the code

Actual behavior

because no PDBs + source info are found, debugger steps over

Solution:

enable SourceLink + pack PDBs inside the NuGet package to fetch the source from github during debugging to be able to step into the code.

@Mike-E-angelo Mike-E-angelo self-assigned this Nov 24, 2018
@Mike-E-angelo Mike-E-angelo added the developer experience Impacts how developers are using this product label Nov 24, 2018
@Mike-E-angelo Mike-E-angelo added this to the 2.1.14 milestone Nov 24, 2018
@Mike-E-angelo Mike-E-angelo added the enhancement (cc: feat) New feature or request label Nov 24, 2018
@Mike-E-angelo
Copy link
Member

Cool @MagicAndre1981 thanks for pointing this out and for the helpful report/links.

I have taken my shot at this here. Please try 2.1.14 and let me know how you do:
https://www.nuget.org/packages/ExtendedXmlSerializer/2.1.14

@MagicAndre1981
Copy link
Author

I'll test this on Monday in office

@WojciechNagorski
Copy link
Member

I was thiniking about this dotnet/BenchmarkDotNet#967. I did it in BenchmarkDotNet. But I don't know difference between it and source link. I want to use Cake script in extendedxmlserializer.

@Mike-E-angelo
Copy link
Member

Boh! Sorry about that, @wojtpl2 I think I stepped on your toes there since this is technically deployment-based stuff. Yes, of course. Please feel free to use whatever you like and to fix any changes I made. :)

@MagicAndre1981
Copy link
Author

it works fine so far. I can easily step through the code of the lib during debugging 😍👍

@WojciechNagorski
Copy link
Member

@Mike-EEE You did a great job and you can do with this repo whatever you want. I trust you ;)

I wrote that Nuget Symbol Server is a new technology but I don't know yet any props and cons yet.
https://blog.nuget.org/20181116/Improved-debugging-experience-with-the-NuGet-org-symbol-server-and-snupkg.html

@WojciechNagorski
Copy link
Member

I think we can close this issue right now. 👍

@WojciechNagorski
Copy link
Member

@MagicAndre1981 Thanks for help.

@Mike-E-angelo
Copy link
Member

Cool... late to the party here due to some technical difficulties with some equipment here. Glad to hear everything works! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Impacts how developers are using this product enhancement (cc: feat) New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants