Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Search comming from query string is url encoded #140

Closed
mshannaq opened this issue Jan 30, 2024 · 0 comments · Fixed by #141
Closed

Bug: Search comming from query string is url encoded #140

mshannaq opened this issue Jan 30, 2024 · 0 comments · Fixed by #141
Labels
bug Something isn't working
Milestone

Comments

@mshannaq
Copy link
Member

mshannaq commented Jan 30, 2024

Describe the bug
when the search string is comming from query string it is encoded so we must decode it before seach to return valid result.

To Reproduce
Steps to reproduce the behavior:

  1. login as user
  2. goto List Urls Bucket
  3. try to seach for any link with not Ebnglis Search , for example try Arabic string
  4. copy the url.
  5. open new browser window and paste the URL.
  6. you will that the query string is used as encoded. see the picture above . and that will not return and result.

Screenshots
image

Also if user listing his url the link will contacins his id , so if her shared the url to another user so the new user will not see the url.

see:
image

Affected version

  • SmartyURL Version: v0.0.0-dev-dnd.7
@mshannaq mshannaq added the bug Something isn't working label Jan 30, 2024
@mshannaq mshannaq added this to the 1.0.0-dev milestone Jan 30, 2024
@mshannaq mshannaq linked a pull request Feb 25, 2024 that will close this issue
mshannaq added a commit that referenced this issue Feb 25, 2024
bug: fix encoded search query string #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant