Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version/0.0.6 #77

Merged
merged 75 commits into from
Dec 24, 2014
Merged

Version/0.0.6 #77

merged 75 commits into from
Dec 24, 2014

Conversation

EyalAr
Copy link
Owner

@EyalAr EyalAr commented Nov 29, 2014

  1. GIF format support (GIF support #33)
  2. 'getPixel' method to get the color of a pixel (Get a pixel by its coordinates #44)
  3. 'setPixel' method to set the color of a pixel (Set pixel color #45)
  4. 'Contain' method (Resize image without stretch #68, resize without distorting (crop and pad) #88)
  5. 'Cover' method (resize without distorting (crop and pad) #88)
  6. Extend 'open' method to open raw pixels buffers (pass in a raw pixelBuffer to the open command #86).
  7. Run automated builds on Windows machine with AppVeyor (one step closer to distribution of pre-built binaries).

Note: giflib uses c99 features (bool type, specifically). This causes further restrictions when compiling on Windows, since c99 is only supported from VS2013. Until pre-built binaries are provided, users installing this module on Windows must have Visual Studio 2013 or later.

EyalAr added 28 commits November 25, 2014 21:16
@EyalAr
start work on #33
6f80564 
add giflib source and include it binding.gyp
@EyalAr
start work on #44 - get pixel
20a9c9a
@EyalAr
use v8 array as return type for getPixel
920c828
@EyalAr
validate getPixel arguments. return a color object
2ae7a05
@EyalAr
add tests for getPixel
7094d33
@EyalAr
add getPixel docs to the readme
efae86a
@EyalAr
register 'color' type with decree, instead of manually validating
3bb4656
@EyalAr
start work on #45 - set pixel
322bc53
@EyalAr
add setPixel tests
04341f2
@EyalAr
make normalizeColor assign default alpha value instead of validateColor
b8ec93e
@EyalAr
add setPixel method to Image and Batch prototypes
c3d53e6
@EyalAr
Merge branch 'feature/decree-color-type' into feature/set-pixel
6b79555
@EyalAr
fix typo
76dab21
@EyalAr
add coordinates validation to setPixel
8a94d43
@EyalAr
Merge branch 'feature/decree-color-type' into feature/get-pixel
9d11c60
@EyalAr
add 'interpolation' decree custom type
9ed00ee
@EyalAr
add 'axes' decree custom type
9b3e041 
this commit makes axes case sensitive
@EyalAr
add 'image' decree custom type
e092fbc
@EyalAr
init prototypes from index.js
14ce65d
@EyalAr
add png and jpg params validators
f1e9b7d
@EyalAr
Merge branch 'feature/decree-custom-types' into feature/get-pixel
33adfe5 
Conflicts:
	lib/Image.js
@EyalAr
fix previous merge
076e5ff 
'getPixel' was accidentally removed
@EyalAr
Merge branch 'feature/decree-custom-types' into feature/set-pixel
56b11aa 
Conflicts:
	lib/Batch.js
	lib/Image.js
@EyalAr
fix setPixel args validation test
986d471
@EyalAr
Merge branch 'feature/get-pixel' into feature/set-pixel
01263a9 
Conflicts:
	lib/ImagePrototypeInit.js
@EyalAr
remove 'setPixel' from random batch test generator
8615f1f 
...as it may sometimes fail due to our of bounds coordinates when image
is randomly resized (for example).
@EyalAr
adds readme docs and an example for setPixel
03d1782
@EyalAr
closes #73 - add 'paste' lock and release tests
9a126b4
@coveralls
Copy link

Coverage Status

Coverage increased (+1.58%) when pulling 9a126b4 on version/0.0.6 into 84ed584 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.53%) when pulling 115c3e9 on version/0.0.6 into 84ed584 on master.

@EyalAr
add tests for image.contain
85b1bb6
@EyalAr
update readme with image.contain
02a8020
@EyalAr
#88 - image.cover
e069b46
@EyalAr
Merge pull request #90 from EyalAr/feature/contain
8e97f5d 
Feature/contain
@EyalAr
Merge branch 'feature/cover' into version/0.0.6
acc56e2 
Conflicts:
	README.md
	lib/BatchPrototypeInit.js
	lib/ImagePrototypeInit.js
	lib/defs.js
	tests/03.safety/00.locks.js
	tests/03.safety/01.releases.js
	tests/utils.js
@coveralls
Copy link

Coverage Status

Coverage increased (+1.61%) when pulling acc56e2 on version/0.0.6 into 84ed584 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.61%) when pulling 0bcfd76 on version/0.0.6 into 84ed584 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.61%) when pulling e9b5207 on version/0.0.6 into 84ed584 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.61%) when pulling cce0af9 on version/0.0.6 into 3bca525 on master.

EyalAr added a commit that referenced this pull request Dec 24, 2014
@EyalAr
Merge pull request #77 from EyalAr/version/0.0.6
f8753d6 
Version/0.0.6
@EyalAr EyalAr merged commit f8753d6 into master Dec 24, 2014
@EyalAr EyalAr deleted the version/0.0.6 branch December 24, 2014 04:22
@jengel3
Copy link

jengel3 commented Dec 24, 2014

Awesome job!

@EyalAr
Copy link
Owner Author

EyalAr commented Dec 24, 2014

Thanks!

toolness added a commit to toolness/teach.webmaker.org that referenced this pull request Jun 15, 2015
@toolness
Make gulp-image-converter work on Windows.
90d3b6e 
This involves downgrading lwip to v0.0.5 because newer versions
require VS2013: EyalAr/lwip#77
@toolness toolness mentioned this pull request Jun 15, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EyalAr @coveralls @jengel3 @wouterverweirder