forked from WISCENTD-UPC/Bulk-Load
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/download template redesign #342
Open
gqcorneby
wants to merge
8
commits into
development
Choose a base branch
from
feature/download-template-redesign
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+462
−298
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4c2d642
download template page redesign
gqcorneby 3f125d4
add periods section
gqcorneby 3956019
add periods section
gqcorneby bfbee3f
cleanup section and templateselector
gqcorneby 6c03661
Merge branch 'feature/download-template-redesign' of https://github.c…
gqcorneby 7d1a064
add buildClassNames, clean up, prettify
gqcorneby b8b34e7
cleanup help icon
gqcorneby 8704405
Use useMemo to keep subSectionClasses immutable
tokland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import { Icon, IconButton, makeStyles, Paper } from "@material-ui/core"; | ||
| import React from "react"; | ||
| import { buildClassName } from "../../utils/reactHelpers"; | ||
|
|
||
| type IconPosition = "left" | "right"; | ||
| type ArrowStyle = "up_down" | "right_left" | "down_right"; | ||
|
|
||
| interface SectionProps { | ||
| isOpen?: boolean; | ||
| setOpen?: (open: boolean) => void; | ||
| children: React.ReactNode; | ||
| title: React.ReactNode; | ||
| collapsible?: boolean; | ||
| elevation?: number; | ||
| iconPos?: IconPosition; | ||
| classProps?: { | ||
| sectionPaper?: string; | ||
| sectionHeader?: string; | ||
| sectionContent?: string; | ||
| }; | ||
| arrowStyle?: ArrowStyle; | ||
| } | ||
|
|
||
| export const Section = (props: SectionProps) => { | ||
| const { | ||
| children, | ||
| title, | ||
| collapsible, | ||
| isOpen = true, | ||
| setOpen = () => {}, | ||
| elevation = 1, | ||
| iconPos = "right", | ||
| classProps = {}, | ||
| arrowStyle = "up_down", | ||
| } = props; | ||
| const classes = useStyles(); | ||
| const leftIcon = iconPos === "left" ? classes.leftIcon : null; | ||
| const toggle = () => setOpen(!isOpen); | ||
|
|
||
| return ( | ||
| <Paper elevation={elevation} className={buildClassName([classes.paper, classProps.sectionPaper])}> | ||
| <div | ||
| className={buildClassName([ | ||
| classes.header, | ||
| leftIcon, | ||
| classProps.sectionHeader, | ||
| isOpen ? null : classes.noBorder, | ||
| ])} | ||
| onClick={toggle} | ||
| > | ||
| {collapsible && leftIcon && <CollapsibleToggle isOpen={isOpen} arrowStyle={arrowStyle} />} | ||
| {title} | ||
| {collapsible && !leftIcon && <CollapsibleToggle isOpen={isOpen} arrowStyle={arrowStyle} />} | ||
| </div> | ||
| <div className={buildClassName([classProps.sectionContent, isOpen ? null : classes.hidden])}> | ||
| {children} | ||
| </div> | ||
| </Paper> | ||
| ); | ||
| }; | ||
|
|
||
| interface CollapsibleToggleProps { | ||
tokland marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| isOpen: boolean; | ||
| arrowStyle: ArrowStyle; | ||
| } | ||
|
|
||
| const CollapsibleToggle = (props: CollapsibleToggleProps) => { | ||
| const { isOpen, arrowStyle } = props; | ||
| const classes = useStyles(); | ||
| const [open, close] = arrowStyle.split("_"); | ||
|
|
||
| return ( | ||
| <IconButton disableTouchRipple={true} style={isOpen ? {} : { left: 0 }} className={classes.button}> | ||
| <Icon>{isOpen ? `keyboard_arrow_${open}` : `keyboard_arrow_${close}`}</Icon> | ||
| </IconButton> | ||
| ); | ||
| }; | ||
|
|
||
| const useStyles = makeStyles({ | ||
| header: { | ||
| margin: 0, | ||
| padding: "1em", | ||
| paddingLeft: 0, | ||
| display: "flex", | ||
| justifyContent: "space-between", | ||
| alignItems: "center", | ||
| borderBottom: "solid 1px #e8edf2", | ||
| cursor: "pointer", | ||
| }, | ||
| noBorder: { border: "none" }, | ||
| leftIcon: { | ||
| justifyContent: "normal", | ||
| gap: 10, | ||
| }, | ||
| paper: { padding: "1em", paddingTop: "0.5em", marginBottom: "1em" }, | ||
| button: { padding: 0 }, | ||
| hidden: { display: "none" }, | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically check fuzzy tags in PO files (gettext adds them, meaning: "I think this is the translation for a new literal I found, which is very similar to another existing, but I am not sure"). We review if correct and the remove the line "#, fuzzy".
BUT, as all the po files already contain fuzzy tags (a lot), you may leave this task to another "cleaning" PR, not in this feature. Confirm with your PM.