Feature/add test cd #63
Conversation
…user updated than update in the script
| clonedInvalidTemplateAuthorities = copyObject(permissionFixerInvalidTemplateGroupsExtended); | ||
| }); | ||
|
|
||
| function getMetadataConfig(): PermissionFixerMetadataConfig { |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| } | ||
|
|
||
| function getMetataConfiThrowInvalidUsergroupException(): PermissionFixerMetadataConfig { | ||
| return configThrowInvalidUsergroupException; |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| } | ||
|
|
||
| function getMetataConfigWithExcludedUser(): PermissionFixerMetadataConfig { | ||
| return configWithUserExcluded; |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| } | ||
|
|
||
| function getWrongMinimalUserGroupConfig(): PermissionFixerMetadataConfig { | ||
| return configWithWrongMinimalGroup; |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| } | ||
|
|
||
| function getValidUser(): PermissionFixerUser { | ||
| return clonedValidUser; |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| } | ||
|
|
||
| function getInvalidUser(): PermissionFixerUser { | ||
| return clonedInvalidUser; |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| } | ||
|
|
||
| function getUserWithoutGroup(): PermissionFixerUser { | ||
| return clonedFakeUserWithoutGroup; |
There was a problem hiding this comment.
This function is not necessary and generate noise, you can use the variable direcly
| ); | ||
| return useCase; | ||
| } | ||
| function givenBasicConfigRepository() { |
There was a problem hiding this comment.
There are a lot of similar functions here where the unique difference is the return when mockedRepository.get() is invoked, You can create a unique function and pass by parameter the data to return.
📌 References
📝 Implementation
Added some test for user-permission script (In this case we change a bit the workflow and I did a manual test also to be sure that nothing is broken).
We could continue adding test due has a lot of corner case to test.
📹 Screenshots/Screen capture
🔥 Notes to the tester
yarn start usermonitoring run-permissions-fixer --config-file config.json