Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide getSchema() and toJSON() for generated version.h to ease usage in HTTP server #526

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Provide getSchema() and toJSON() for generated version.h to ease usage in HTTP server #526

merged 1 commit into from
Nov 29, 2016

Conversation

tribal-tec
Copy link
Member

No description provided.

@tribal-tec tribal-tec mentioned this pull request Nov 28, 2016
Merged
rdumusc
rdumusc reviewed Nov 28, 2016
View reviewed changes
Copy link

@rdumusc rdumusc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move impl to version.cpp?

@tribal-tec
Copy link
Member Author

tribal-tec commented Nov 28, 2016 •
edited
Loading

Gives linker errors as the version file generation is rather messy regarding sublibraries. So no, not moving to cpp.

rdumusc
rdumusc approved these changes Nov 28, 2016
View reviewed changes
Copy link

@rdumusc rdumusc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then. We should think about cleaning these linker issues at some point.

@eile eile merged commit 4f20da0 into Eyescale:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdumusc rdumusc rdumusc approved these changes

Assignees

@eile eile

@rdumusc rdumusc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tribal-tec @rdumusc @eile