Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sideNav #30

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat: sideNav #30

merged 3 commits into from
Oct 3, 2024

Conversation

LucasMaupin
Copy link

@LucasMaupin LucasMaupin commented Oct 3, 2024 •
edited
Loading

Screenshot 2024-10-03 at 14 31 29
Screenshot 2024-10-03 at 14 31 14

@Saelmala
Copy link

Saelmala commented Oct 3, 2024 •
edited
Loading

Overall LGTM, left a couple small comments. I also think that maybe the border around the toggle should not be green when the rest of the toggle isn't green either

image

@LucasMaupin
Copy link
Author

Overall LGTM, left a couple small comments. I also think that maybe the border around the toggle should not be green when the rest of the toggle isn't green either

image

Fixed - it is now gray and barely visible

@malmen237
Copy link

LGTM

@LucasMaupin LucasMaupin merged commit 8535b7c into main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saelmala Saelmala Saelmala approved these changes

@malmen237 malmen237 malmen237 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasMaupin @Saelmala @malmen237