Feat/restyle multiview layout #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saelmala
approved these changes
Oct 9, 2024
LucasMaupin
requested changes
Oct 9, 2024
...components/modal/configureMultiviewModal/MultiviewLayoutSettings/MultiviewLayoutSettings.tsx
Outdated
Show resolved
Hide resolved
malmen237
force-pushed
the
feat/restyle-multiview-layout
branch
from
c540e10
to
1c80347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
More universal
This layout-config is seated at the top of the modal and does not connect to any specific multiview-setting.
The Layout-modal
You begin by choosing a layout to change or just to start fresh from a preset.
Also fixed a bug that did not allow the same layout-names to exist for different productions and if you wrote a layout-name that belonged to a different production it would be found and it's layout added into view.
Some extras
Also added the review-updates requested by Ateliere in the PR. Which mainly is removal of commented-out code and the additional of some empty lines.