feat: add modal for alignment and latency config #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasMaupin
approved these changes
Oct 10, 2024
| @@ -839,6 +850,46 @@ export async function startProduction( | |||
| input_slot: source.input_slot | |||
| }; | |||
| }), | |||
| production_settings: { | |||
| ...production.production_settings, | |||
| pipelines: await Promise.all( | |||
|
Converted this PR to a draft as a different settings-button position will be needed with newest main version |
|
Noticed a bug if you added a source during a running production and opened its settings-modal, will update PR with that fix |
LucasMaupin
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Steps to do so:
Start a production, and click the settings button on the source card.
Set new values
On save: alignment_ms and latency is saved on the pipeline with the source's sourceId as a key. A PATCH request to update the stream's alignment with the new value is also done.
I also added error handeling in case the latency value is set to higher value than the alignment, since if that's the case it will not be possibly to start a production.
On stop and start, there are checks when each stream is created to see if the alignment/latency for that source on each respective pipeline and in that case that value is used, otherwise the pipeline's 'global' value is used.
Images
Settings button on source card:
Configuration modal with initial values
After a stop and start of the production, the new values that have been saved in the database are shown in the modal for that source:
Error handeling if latency > alignment:
