Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicate Lines in UEF ACU Upgrades #6501

Open
MrRowey opened this issue Oct 31, 2024 · 2 comments
Open

Remove Duplicate Lines in UEF ACU Upgrades #6501

MrRowey opened this issue Oct 31, 2024 · 2 comments
Labels
good first issue issue that is relative easy to pick up

Comments

@MrRowey
Copy link
Member

MrRowey commented Oct 31, 2024

Description

When updating enhancements scripts to the new format, it was noticed that the Tech 2 and Tech 3 upgrades have Duplicated Lines.

Course of Action

Remove the duplicated lines of code

Test Plan

Ensure that when removed the upgrade still functions the same

Learning Goals

  • Using Github
  • changing unit files

Progress

No response

@MrRowey MrRowey added the good first issue issue that is relative easy to pick up label Oct 31, 2024
@Garanas
Copy link
Member

Garanas commented Nov 4, 2024

@MrRowey you could improve this issue by referring the module (file) and the function (that you introduced, ha!). That way a new contributor does not have to search for what you're referring to - because if you take the issue on flat value right now then nobody would be able to decipher what it is that you're talking about unless they are already familiar with #6498 😄 !

@MrRowey
Copy link
Member Author

MrRowey commented Nov 6, 2024

ill update this tomorow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue issue that is relative easy to pick up
Projects
None yet
Development

No branches or pull requests

2 participants