-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clan cache warmup #520 #526
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #526 +/- ##
===========================================
- Coverage 41.79% 41.58% -0.22%
===========================================
Files 70 71 +1
Lines 1682 1705 +23
Branches 220 220
===========================================
+ Hits 703 709 +6
- Misses 947 964 +17
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Please use proper PR names as they appear in the changelog |
you could use the names of the ticket aka "524-clan-transfer-ownership", there is even a create branch function in the ticket. |
Address #520 for the most part.
Criteria:
cache will be generated at server start/restart
will be scheduled to refresh it every (ttl - 1min), currently this would be 59min
should not run in parallel with other JavaApi calls if possible (ddos ourself if the list of crawlers getting bigger)
should not crash the server if the JavaApi is not reachable or and exception is happening.
should log if a cache was getting refreshed or when something failed