Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clan update and create message validations #531

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

beckpaul
Copy link
Collaborator

Edit error messages for clan creation/updating to address #528

We may not need the error regarding an empty descriptions as:

title='description',
required='required',

Handles empty for us natively but there no harm in maintaining both errors.

Also included

  • Some styling for the buttons to create and update the clan (see images)
    • Re-add unusused class
    • apply same class to the update button (see screenshots - mostly a top margin change)
  • English change on clan description
    • The description players will see when they look your clan
    • Becomes: The description players will see when they view your clan

Before:
Screenshot 2023-12-14 at 15 49 09
After:
Screenshot 2023-12-14 at 15 49 50

@beckpaul beckpaul changed the title Develop update clan messages Clan update and create message validations Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f8d01b) 41.17% compared to head (6e67c32) 41.17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #531   +/-   ##
========================================
  Coverage    41.17%   41.17%           
========================================
  Files           71       71           
  Lines         1734     1734           
  Branches       210      210           
========================================
  Hits           714      714           
  Misses         988      988           
  Partials        32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps
Copy link
Collaborator

fcaps commented Dec 14, 2023

@beckpaul if you add:
closes #528

merging the pr will automatically close the issue.

@fcaps fcaps merged commit b8240d5 into FAForever:develop Dec 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants