-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition - Secondary account disclaimer #535
Merged
fcaps
merged 15 commits into
FAForever:develop
from
beckpaul:addition/secondary-account-disclaimer
Jan 15, 2024
Merged
Addition - Secondary account disclaimer #535
fcaps
merged 15 commits into
FAForever:develop
from
beckpaul:addition/secondary-account-disclaimer
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #535 +/- ##
===========================================
- Coverage 41.17% 40.62% -0.56%
===========================================
Files 71 72 +1
Lines 1734 1770 +36
Branches 210 214 +4
===========================================
+ Hits 714 719 +5
- Misses 988 1019 +31
Partials 32 32 ☔ View full report in Codecov by Sentry. |
pumbas600
reviewed
Jan 8, 2024
fcaps
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds disclaimer to register page regarding multiple account operation and ownership as well as advise on recovery methods.