Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase pill roundness and horizontal padding #536

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

pumbas600
Copy link
Contributor

Hi 👋

I noticed that the pill buttons on the website in a lot of cases weren't quite rounded enough to be a full pill button.

I also increased the horizontal padding on the buttons which I think improves their shape slightly.

Before After
Before Card After Card
Before Landing After Landing

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8daa828) 41.17% compared to head (d3df235) 41.17%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #536   +/-   ##
========================================
  Coverage    41.17%   41.17%           
========================================
  Files           71       71           
  Lines         1734     1734           
  Branches       210      210           
========================================
  Hits           714      714           
  Misses         988      988           
  Partials        32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps
Copy link
Collaborator

fcaps commented Jan 9, 2024

Hi @pumbas600,
and thx for your PR!

There is css "trick" for doing it without the 9999px border-radius: 25%/50% looks quite similar, you think there are drawbacks?
Other changes looking good to be merged.

@pumbas600 pumbas600 requested a review from fcaps January 11, 2024 09:21
@fcaps fcaps merged commit fb9b90a into FAForever:develop Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants