[BE] lint/test/docs on PR and push to main #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lbluque
commented
Jun 26, 2024
•
lbluque
commented
- Added a push event trigger to run tests on the main branch.
- Added event PR event trigger for lint workflow (this double runs linting, but allows running it on PRs from outside forks).
- Docs building (without deployment) is triggered once a PR review is submitted - this prevents merging PR that break docs.
- Docs building + deployment is triggered when a new release is published.
- Docs are now all fixed (thanks @zulissimeta!).
Codecov ReportAttention: Patch coverage is
|
Run docs CI on every push to main
misko
reviewed
Jun 26, 2024
|
The docs will build on main with this, but the build always succeed even if some of the notebooks fail. I'm looking to see whether there's an easy flag to make the build fail if any notebooks fail so that it's obvious when there's a doc problem. |
lbluque
changed the title
update lint/test/docs
lbluque
changed the title
…to lint-test-triggers
rayg1234
previously approved these changes
Jul 12, 2024
Closed
zulissimeta
approved these changes
Jul 13, 2024
Merged
zulissimeta
added
documentation
misko
pushed a commit
that referenced
this pull request
Jan 17, 2025
* lint/test on PR and push to main * Run docs CI on every push to main * Fail docs when a notebook doesn't build * skip eval_metrics fix in tutorial_utils * when writing extxyz in docs, specific force as a column explicitly * task.dataset -> dataset.format * small fixes in config in tutorial * make train dataset optional if only used test dataset * more small fixes if you don't specify a train dataset * loss_fns -> loss_functions in tutorial * eval_metrics -> evaluation_metrics in OCP tutorial * FixAtoms as int * don't clear train dataset if present but src is missing * invert train dataset load logic * fix logic * bool mask * require docs test on main * pull_request_review to trigger doc build * use FixAtoms fix from stress-relaxations branch * sneak in a push trigger to test docs * upload only html artifact * sneaky push * fix artifact path * fix job names * no deploy docs on push * add devcontainer settings * small fix to legacy tutorial * small fix to legacy tutorial * another small tutorial fix * add rest of tutorial back * clean up logic in load_datasets * typo * logic typo in load_datasets * convert all md to ipynb on launch * add minimum spec on devcontainer to make sure everything runs * include subdirectories in conversion * 758 fix * minor fixes * relax otf * typo * try removing comments in build_docs yml --------- Co-authored-by: zulissimeta <122578103+zulissimeta@users.noreply.github.com> Co-authored-by: Zack Ulissi <zulissi@meta.com> Co-authored-by: Muhammed Shuaibi <mushuaibi@gmail.com> Former-commit-id: c76e5452e86c740ceffb26fe308853328788dfad
beomseok-kang
pushed a commit
to beomseok-kang/fairchem
that referenced
this pull request
Jan 27, 2025
* lint/test on PR and push to main * Run docs CI on every push to main * Fail docs when a notebook doesn't build * skip eval_metrics fix in tutorial_utils * when writing extxyz in docs, specific force as a column explicitly * task.dataset -> dataset.format * small fixes in config in tutorial * make train dataset optional if only used test dataset * more small fixes if you don't specify a train dataset * loss_fns -> loss_functions in tutorial * eval_metrics -> evaluation_metrics in OCP tutorial * FixAtoms as int * don't clear train dataset if present but src is missing * invert train dataset load logic * fix logic * bool mask * require docs test on main * pull_request_review to trigger doc build * use FixAtoms fix from stress-relaxations branch * sneak in a push trigger to test docs * upload only html artifact * sneaky push * fix artifact path * fix job names * no deploy docs on push * add devcontainer settings * small fix to legacy tutorial * small fix to legacy tutorial * another small tutorial fix * add rest of tutorial back * clean up logic in load_datasets * typo * logic typo in load_datasets * convert all md to ipynb on launch * add minimum spec on devcontainer to make sure everything runs * include subdirectories in conversion * 758 fix * minor fixes * relax otf * typo * try removing comments in build_docs yml --------- Co-authored-by: zulissimeta <122578103+zulissimeta@users.noreply.github.com> Co-authored-by: Zack Ulissi <zulissi@meta.com> Co-authored-by: Muhammed Shuaibi <mushuaibi@gmail.com> Former-commit-id: da152c95058bdeca87deff82f4e1e33c1f8cddca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.