Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide wandb.watch behind flag #747

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Hide wandb.watch behind flag #747

merged 3 commits into from
Jul 2, 2024

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Jul 2, 2024 •
edited
Loading

wanbd.watch logs too much data and makes the UI slow, turn it off by default.

Example usage (config in yaml):

logger:
  name: wandb
  entity: fairchem
  project: fm_testing
  watch: 1000

the number specifies the frequency (in # of steps) to log gradients etc..

Run without watch: https://fairwandb.org/fairchem/fm_testing/runs/2024-07-02-16-12-48-local_test_no_watch
Run with watch: https://fairwandb.org/fairchem/fm_testing/runs/2024-07-02-16-10-40-local_test_watch

@rayg1234 rayg1234 requested a review from yilunliao July 2, 2024 16:15
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/fairchem/core/common/logger.py 72.22% <75.00%> (-3.97%) ⬇️
src/fairchem/core/trainers/base_trainer.py 86.26% <50.00%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

@rayg1234 rayg1234 requested review from misko and wood-b July 2, 2024 17:54
@rayg1234 rayg1234 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 657598b Jul 2, 2024
5 checks passed
@rayg1234 rayg1234 deleted the rgao_switch_off_watch_by_default branch July 2, 2024 22:03
levineds pushed a commit that referenced this pull request Jul 11, 2024
@rayg1234
Hide wandb.watch behind flag (#747)
5ecd544 
* hide watch behind flag

* set frequency
misko pushed a commit that referenced this pull request Jan 17, 2025
@rayg1234
Hide wandb.watch behind flag (#747)
2f7ac39 
* hide watch behind flag

* set frequency

Former-commit-id: 2d8bb728b0cc6373683b0ffdc8621d4fbac053a3
beomseok-kang pushed a commit to beomseok-kang/fairchem that referenced this pull request Jan 27, 2025
@rayg1234
Hide wandb.watch behind flag (FAIR-Chem#747)
1d77e20 
* hide watch behind flag

* set frequency

Former-commit-id: d96aa52df1267efbab698cac5927a355fc2849fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misko misko misko approved these changes

@yilunliao yilunliao Awaiting requested review from yilunliao

@wood-b wood-b Awaiting requested review from wood-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayg1234 @misko