Sort dbs AseDBDataset #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
mshuaibii
approved these changes
Sep 9, 2024
|
What are you using to create metadata files for these? I assume it's not https://github.com/FAIR-Chem/fairchem/blob/main/src/fairchem/core/scripts/make_lmdb_sizes.py. |
misko
pushed a commit
that referenced
this pull request
Jan 17, 2025
Former-commit-id: ec7b44da1f5c90bcc9943d4ff64030703a03a856
beomseok-kang
pushed a commit
to beomseok-kang/fairchem
that referenced
this pull request
Jan 27, 2025
Former-commit-id: 4cf36c31c37f15d3a73f0e34484499f07c9553ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort when loading many db files to ensure that the entries single metadata file corresponds to the dataset.