Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication use .item(); fix hydra_cli #920

Merged
merged 10 commits into from
Nov 20, 2024
Merged

replication use .item(); fix hydra_cli #920

merged 10 commits into from
Nov 20, 2024

Conversation

kyonofx
Copy link
Collaborator

@kyonofx kyonofx commented Nov 18, 2024

No description provided.

@kyonofx kyonofx added enhancement New feature or request minor Minor version release labels Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/_cli_hydra.py 27.27% 8 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/common/utils.py 67.33% <ø> (-0.94%) ⬇️
src/fairchem/core/_cli_hydra.py 70.14% <27.27%> (-4.86%) ⬇️

... and 2 files with indirect coverage changes


🚨 Try these New Features:

@kyonofx kyonofx requested review from rayg1234 and misko November 19, 2024 18:09
Copy link
Collaborator

@rayg1234 rayg1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@kyonofx kyonofx added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 8ecdeea Nov 20, 2024
8 checks passed
@kyonofx kyonofx deleted the fxdev branch November 20, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants