Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda set_device for local run #931

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Add cuda set_device for local run #931

merged 4 commits into from
Dec 5, 2024

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Dec 4, 2024

I was hoping to remove this way of assigning devices to GPUs but FSDP (https://pytorch.org/docs/main/fsdp.html#torch.distributed.fsdp.FullyShardedDataParallel) still requires it so we need to keep this code and to make local mode work with >1 GPU, we need to set it here as well

@rayg1234 rayg1234 added bug Something isn't working patch Patch version release labels Dec 4, 2024
@rayg1234 rayg1234 requested a review from misko December 4, 2024 21:32
@rayg1234 rayg1234 marked this pull request as ready for review December 4, 2024 21:32
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/common/distutils.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/common/distutils.py 56.46% <50.00%> (-0.09%) ⬇️

Copy link
Collaborator

@misko misko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rayg1234 rayg1234 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 6ab6ad7 Dec 5, 2024
8 checks passed
@rayg1234 rayg1234 deleted the rgao_fix_local_n_gpurun branch December 5, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Patch version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants