This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
[INDEX-7] Introduce webhooks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekSuchanek
force-pushed
the
feature/INDEX-7
branch
from
8dd133d to
82ca858
Compare
MarekSuchanek
force-pushed
the
feature/INDEX-7
branch
from
f0d2719 to
7c6a87c
Compare
MarekSuchanek
force-pushed
the
feature/INDEX-7
branch
from
7c6a87c to
e5f90e3
Compare
kburger
reviewed
Aug 31, 2020
| @@ -199,7 +199,7 @@ private void resumeUnfinishedEvents() { | |||
| } else if (event.getType() == EventType.WebhookTrigger) { | |||
| webhookService.processWebhookTrigger(event); | |||
| } else { | |||
| logger.warn("Unknown event type " + event.getUuid()); | |||
| logger.warn("Unknown event type " + event.getUuid() + " (" + event.getType() + ")"); | |||
There was a problem hiding this comment.
slf4j loggers can use the {} placeholder syntax (which would prevent unnecessary string concatenation):
Suggested change
| logger.warn("Unknown event type " + event.getUuid() + " (" + event.getType() + ")"); | |
| logger.warn("Unknown event type {} ({}) ", event.getUuid(), event.getType()); |
There was a problem hiding this comment.
Nice catch, fixed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.