Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Install xvfb in Jammy image #1997

Merged
merged 2 commits into from
Sep 26, 2023
Merged

➕ Install xvfb in Jammy image #1997

merged 2 commits into from
Sep 26, 2023

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Sep 26, 2023

Fixes

Fixes https://cmi-cnl.slack.com/archives/GC8KKE490/p1693505192148309?thread_ts=1693325531.117369&cid=GC8KKE490 by @nx10
Fixes https://cmi-cnl.slack.com/archives/GC8KKE490/p1693505884160539?thread_ts=1693325531.117369&cid=GC8KKE490 by @e-kenneally
Fixes #1971 by @shnizzedy
Fixes #1981 by @shnizzedy

Description

Installs xvfb in Jammy base OS image.

Technical details

#1981 moved the Python wrapper installation into C-PAC's install requirements, but that doesn't install the core package.

Tests

def _installation_check(command: str, flag: str) -> None:
"""Test that command is installed by running specified version or
help flag.
Parameters
----------
command : str
Command to run.
flag : str
Version or help flag to run.
Raises
------
AssertionError
If command is not installed.
Returns
-------
None
"""
_, exit_code = log_subprocess([command, flag])
assert exit_code == 0
@pytest.mark.parametrize("executable", ["Xvfb"])
def test_executable(executable):
"""Make sure executable is installed"""
_installation_check(executable, "-help")

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[rebuild Ubuntu.jammy-non-free]
[rebuild base-standard]
[rebuild base-lite]
@shnizzedy shnizzedy added bug devops dependencies Pull requests that update a dependency file develop issue on `develop` branch labels Sep 26, 2023
@shnizzedy shnizzedy self-assigned this Sep 26, 2023
@shnizzedy shnizzedy requested a review from a team September 26, 2023 14:37
@shnizzedy shnizzedy added this to the 1.8.6 release milestone Sep 26, 2023
@shnizzedy shnizzedy marked this pull request as ready for review September 26, 2023 14:37
@shnizzedy shnizzedy merged commit a892846 into develop Sep 26, 2023
@shnizzedy shnizzedy deleted the jammy/xvfb branch November 6, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file develop issue on `develop` branch devops
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants