Option-forked nodeblock missing resource name reporting #2028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Technical details
Option-forked nodeblock lists only report the name of the last nodeblock in the list when a missing resource is reported.
E.g.:
Users will see
while the nodeblock not necessarily has anything to do with the missing resource.
Now they will see:
Which is also not ideal, as it also does not point to the specific nodeblock that causes the problem, but at least it will contain it.
To properly point the issue-causing one out bigger engine modifications are necessary (such as appending nodeblock information to the
LookupError
as it happens).Generally the mechanism by which some NodeBlock instances can be lists of nodeblocks while others are single ones might be worth to restructure a bit as in this loop every time a local field like
name
is set it will end up being the name of the last nodeblock in that list which could cause similar unexpected behavior throughout the codebase.Checklist
Update index.md
).develop
branch of the repository.Developer Certificate of Origin
Developer Certificate of Origin