Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Throttle calc_ants_warp, cal_DVARS and all cosine_filters #2081

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

shnizzedy
Copy link
Member

Fixes

Fixes #2057 (comment) by @shnizzedy
Maybe fixes #1301 by @sgiavasis
Maybe fixes #1308 by @cbin-cnl

Description

  • Throttles all cosine_filters
  • Throttles calc_ants_warp
  • Throttles cal_DVARS

Technical details

If we want some but not all of these, we can cherry-pick them into #2073 or revert the ones we don't want here before merging.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the throttle branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sgiavasis
Copy link
Collaborator

Maybe fixes #1301 by @sgiavasis

Hopefully! I love seeing cold cases get solved.

@sgiavasis sgiavasis merged commit 41bba7d into throttle Mar 13, 2024
43 checks passed
@shnizzedy shnizzedy deleted the also-throttle branch March 13, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants