Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Patch NetCorr._list_outputs #2163

Merged
merged 2 commits into from
Nov 21, 2024
Merged

🐛 Patch NetCorr._list_outputs #2163

merged 2 commits into from
Nov 21, 2024

Conversation

shnizzedy
Copy link
Member

Related to

Related to Slack thread p1731021618662679p1731107909945459 by @birajstha, @tamsinrogers, @sgiavasis & @shnizzedy
Related to nipy/nipype#3696 by @shnizzedy
Related to nipy/nipype#3697 by @shnizzedy

Description

Includes the fix from nipy/nipype#3697 in C-PAC without waiting for the fix to be released in Nipype and then updating the Nipype version in the C-PAC container.

Technical details

List of changes proposed in this PR (pull-request)

nipy/nipype#3697 (comment)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the merged_many_pipes branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added the bug label Nov 11, 2024
@shnizzedy shnizzedy added this to the 1.8.8 release milestone Nov 11, 2024
@shnizzedy shnizzedy self-assigned this Nov 11, 2024
@sgiavasis sgiavasis merged commit 12bc033 into merged_many_pipes Nov 21, 2024
24 checks passed
@shnizzedy shnizzedy deleted the ts_Z_corr branch November 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants