-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements for binapigen #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for loading external plugins (as pre-compiled library) Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
This was referenced Feb 2, 2023
- add helper methods and constructors for IP, MAC types - regenerate binapi - add more comments to code Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
sknat
reviewed
Feb 23, 2023
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
# Conflicts: # go.mod
sknat
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the big refactoring !
I think the main thing to discuss is the plugin API
Otherwise lgtm 😄
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
sknat
reviewed
Mar 2, 2023
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
sknat
previously approved these changes
Mar 2, 2023
lgtm ! Thanks 😄 |
# Conflicts: # go.mod
sknat
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains enhancements for the binapi-generator and binapigen package. The aim was to finish the implementation of generator plugins and allow adding custom plugins by users.
This change contains the following changes:
*.so
) compiled from Go main package usinggo build -buildmode=plugin ...
GenerateFile(g *binapigen.Generator, f *binapigen.File) *binapigen.GenFile
(runs once for each file)GenerateAll(g *binapigen.Generator) []*binapigen.GenFile
(runs only once for all)plugin
package)/usr/share/vpp/api
)make json-api-files
automatically)Address
,MacAddress
,Prefix
, .. into types fromnet
package (IP
,IPNet
...)binapigen
packageThis PR includes collective changes from Nathan's PRs: #67 #68
There is a discussion created for design and overall info for this feature: #94