parallel and asynchronous output writing #14

hegish · 2020-09-21T11:47:54Z

No description provided.

… to make it consistent with the rest of the file and simplify searching the text for procedure/type use cases

…uded file, fix indentation

…r intention

…ally in each depending procedure instead - directly 'use' modules which contain the symbols we need, not any other module which happens to expose these symbols

- do not postpone netcdf errors, instead fail immediately

…ause for each different data type

- remove extra calculation step when when computing means

…lves, so we control its contents)

…imension=1, remove all related if clauses

…module to a separate file

- fix erroneous receive buffer allocation

- rename remote rank variable

…ine by line basis

… use them concurrently - use variable tag for gather_* procedures to be able to use them concurrently

… multiple Meandata fields at the same time

… a specific kind here

… on a process

…erived types with pointers

…put field if there are sufficient FESOM processes available

…ndata member and allocate only once

…08e1334)

…mplicitly 'pass' or the cray ftn compiler will choke on it

…s on the cray environment - enable full cray-mpich thread support

parallel and asynchronous output writing

hegish added 30 commits August 31, 2020 13:20

fix typo in message to user

2db3ddf

fix typos in comments

80b1c5b

remove disabled (commented) code lines

08b7fb1

remove repetition of name of a declaration block in its end statement…

1d64380

… to make it consistent with the rest of the file and simplify searching the text for procedure/type use cases

do not expose internal symbols via public statement

107cf25

remove unused variables

c1381d1

simplify get_dimname function, remove dependency to preprocessor incl…

4d5124c

…uded file, fix indentation

rename get_dimname procedure and its arguments to better express thei…

7419792

…r intention

remove unused module dependencies

91bd41d

- do not export symbols from 'use'd modules where possible, 'use' loc…

f483abe

…ally in each depending procedure instead - directly 'use' modules which contain the symbols we need, not any other module which happens to expose these symbols

fix typos in messages to user

4d6d59d

create module to manage data type specific I/O implementation

42bdbb7

remove support for 2 byte integer output

3f3a296

- do not allocate error_status(10000) array for each process

7964d7d

- do not postpone netcdf errors, instead fail immediately

use data strategy to create the netcdf data variable without an if cl…

68f689e

…ause for each different data type

- remove implicit rounding from real(8) to real(4) when computing means

df96e20

- remove extra calculation step when when computing means

remove impossible to reach else if blocks for ndim (we set ndim ourse…

e53124b

…lves, so we control its contents)

treat the data pointer for 2d the same as for 3d but with the third d…

a55c607

…imension=1, remove all related if clauses

simplify adding new data to our local values

1770630

add procedures to add values to the io data strategy

d48462d

check if given accuracy is available only once

9579b7c

copy mpi subroutines from the g_comm_auto module used by io_MEANDATA …

dab0f44

…module to a separate file

fix indentation for io gather_nod2D

040b7db

- remove erroneous if clause in io gather_nod2D

3f1877c

- fix erroneous receive buffer allocation

- add argument to io gather_nod2D to set the receiving rank

9af4bfb

- rename remote rank variable

change variable names to improve readability

d7b753b

extend io gather_nod2D to be able to gather to any process rank

9b09ba3

do not bcast the rank0Dim_nod2D, we can compute it locally

0eb72bf

fix indentation for io gather_elem2D

2efb15e

remove erroneous if clause

717e3cb

hegish added 26 commits August 31, 2020 13:20

fix spelling error in message to user

50d8e8b

make the def_stream 2D/3D subroutines use the same code layout on a l…

f633e8d

…ine by line basis

use identical bounds check for def_stream 2D/3D

fea0476

fix precision error when initializing and resetting the local mean data

0d1e4a1

rearrange def_stream 2D/3D to have non specific code at the end

82f2771

move duplicate end part from def_stream 2D/3D to separate procedure

57c7b14

make gather_* procedures thread-safe

6fe13e0

- use separate MPI communicator for gather_* procedures to be able to…

d144252

… use them concurrently - use variable tag for gather_* procedures to be able to use them concurrently

be able to use different MPI communicators in case we gather data for…

ead0e25

… multiple Meandata fields at the same time

allow "kind of type" via class keyword as some compilers do not allow…

c0fe724

… a specific kind here

report process use count when suggesting to reject an async operation…

aef0911

… on a process

make root_rank a member of the Meandata type

655fd94

specify wether it is a 3D or 2D output variable in the console message

93af9f1

add assertion subroutine to bail out on errors

6219477

do not dynamically increase Meandata array as this fails for nested d…

86a519b

…erived types with pointers

set individual processes to write each output field

acfa495

use an individual tag when gathering output fields

81286f1

automatically use threads to asynchronously gather and write each out…

0fe8302

…put field if there are sufficient FESOM processes available

we can not share the field global temporary data, make aux_r8/4 a Mea…

0e0bdca

…ndata member and allocate only once

remove experimental callback for writing real 8 fields (i.e. revert 0…

f912514

…08e1334)

use the original fixed message tag for gathering

f1e12cb

do not explicitly make procedures 'pass' if their interface is only i…

de49629

…mplicitly 'pass' or the cray ftn compiler will choke on it

- work around an error with multi threaded calls and invalid variable…

a435244

…s on the cray environment - enable full cray-mpich thread support

append to existing output files

28cbd45

print available MPI thread support level to the console

6596423

flush output file to disk after each write

c566d26

koldunovn mentioned this pull request Sep 30, 2020

AWICM3 changes to coupling, restart file writing and DMOC #15

Merged

dsidoren merged commit 6ffab28 into master Oct 2, 2020

koldunovn deleted the async_output branch January 28, 2021 16:49

wiltonloch pushed a commit to wiltonloch/fesom2 that referenced this pull request Feb 1, 2023

Merge pull request FESOM#14 from FESOM/async_output

2c1f358

parallel and asynchronous output writing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

parallel and asynchronous output writing #14

parallel and asynchronous output writing #14

hegish commented Sep 21, 2020

parallel and asynchronous output writing #14

parallel and asynchronous output writing #14

Conversation

hegish commented Sep 21, 2020