Workbench merge cavity #48
Conversation
…out level index for cavity-ocean boundary at vertices and elements and cavity flag index at vertices
…avity level inforcmation cavity_nlvls.out or cavity_elvls.out > 1 than cavity_flag_n, cavity_flag_e = 1 otherwise 0
…nod2D, and correct bug in the computation of ulevels_nod2D
…ng debugging mark and comments
… valid ocean layers
…face level depth, correct bug in init_stiffmat,...
…e partial cells are used
…els (Z --> Z_3d_n) when using partial cells as well as zlevel and zstar
…vels (Z --> Z_3d_n) when using partial cells as well as zlevel and zstar when computing sw_alpha and sw_beta
… and the computation of the buoyancy with respect to the surface dbsfc
…proper insitu density
…ion of fesom2.0, prepare cavity branch for merging
|
found a bug next try |
…avity boundary condition
|
@patrickscholz do you think we need to change results of the tests, or you will try to reproduce the old values with your code? |
…lag to switch off CFL warning
Patrick, I went through the code, looks cool. Due to the large amount of changes, however, there is no chance to detect any error but it is clear what you did. The tests, however, failed. How shall we proceed? What could be the reason for failing? |
|
@dsidoren , @koldunovn Mfg Patrick |
|
@dsidoren and @koldunovn So i rechecked my Cavity stuff and found the bug that messes the things up. I also checked over Christmas if there are any strange features/biases of the new code compared to the old one (master). Except the typical random background bias pattern of ollie i couldn't find any additional major biases the poke out of the background bias. So I think the branch could be merged. |
Workbench merge cavity
Hey Dima, my early Chrismas Present to you, happy merging, Ho Ho Ho ?!
merge CAVITY into master:
so far CAVITY works well with linfs, for zstar and zlevel issue below need to be solved
there is still an open issue with computing PGF via density (without cavity-ocean pressure boundary condition), the PGF computation via pressure (Sergeys Idea) seems to work