Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Refactoring addsshsubcycl #497

Merged
merged 60 commits into from
Aug 16, 2024
Merged

Draft: Refactoring addsshsubcycl #497

merged 60 commits into from
Aug 16, 2024

Conversation

patrickscholz
Copy link
Contributor

No description provided.

@patrickscholz
add fortran file for ssh split explicite subcycling
9213bca
@patrickscholz
add additional variables for split-explicite ssh subcycling computation
8210cc5
@patrickscholz
add additional variables for split-explicite ssh subcycling computation
f4cc3d1
@patrickscholz
improve flag for use_ssh_splitexpl_subcycl=.false.
1d781ca
@patrickscholz
add subroutine momentum_adv_scalar_4splitexpl for momentum advection …
8f7e0fd 
…when split-explicite scheme is used
@patrickscholz
add transport velocties
e524698
@patrickscholz
addapt visc filter towards transport velocity update
9260839
@patrickscholz
add and rename some variables that are need for split-explicite subsa…
56f5a41 
…mpling
@patrickscholz
add viscfilter option 5 for transport velocities
5e46284
@patrickscholz
restructure/comment oce_timestep for split-explicite subcycling routines
e6c83c8
@patrickscholz
add routines for split-explicite subcycling from sergeys prototyp rou…
83a5566 
…tines
@patrickscholz
add comments and explanations to adams-bashfort
fc4897b
@patrickscholz
actualise and add some comments and explanations
466e3d7
@patrickscholz
add some more comments and change some varaible names
07282eb
@patrickscholz
....
7636ceb
@patrickscholz
add split-explicite blowup variables
a494f98
@patrickscholz
fix big in vertical integral of UVBT_4AB, fix bug in SE namelist par…
4c7f9a3 
…ameter, switch back on tracer solver + some cosmetics
@patrickscholz
fix small bug in vertical loop
cdb4c4e
@patrickscholz
fix declaration bug
ae5bf22
@patrickscholz
fix interfasce problem
042a7be
@patrickscholz
still try to fix this interface
edba366
@patrickscholz
still try to fix this interface
748f801
@patrickscholz
still try to fix this interface
ec17f24
@patrickscholz
fix interface problem for the moment
83b7381
@patrickscholz
fix indices problem in curl computation
e989cd5
@patrickscholz
small fix indices limit
cb95235
@patrickscholz
add stabilisation for splitexplicite, add longer term stable core2 p…
9d48d8d 
…arameters for split expl
@patrickscholz
update changes to subcycling, try to make energy diagnostic consiste…
f7b7dcd 
…nt with subcycling
@patrickscholz
solve merging conflict
6c364b2
@patrickscholz
make loops OMP conform, reduce allocation of bottomdrag and UVBT_har…
2bcb58b 
…mvisc array
suvarchal and others added 9 commits October 26, 2023 22:10
@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Feb 28, 2024
@patrickscholz patrickscholz added the help wanted Extra attention is needed label Mar 12, 2024
@patrickscholz patrickscholz changed the title Refactoring addsshsubcycl Draft: Refactoring addsshsubcycl Mar 12, 2024
@JanStreffing JanStreffing marked this pull request as draft March 12, 2024 13:08
@JanStreffing JanStreffing mentioned this pull request Mar 13, 2024
Closed
@patrickscholz patrickscholz marked this pull request as ready for review June 14, 2024 10:23
@JanStreffing JanStreffing changed the base branch from refactoring to main June 21, 2024 08:06
@JanStreffing JanStreffing merged commit 2a68b33 into main Aug 16, 2024
4 checks passed
@JanStreffing JanStreffing deleted the refactoring_addsshsubcycl branch August 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanStreffing JanStreffing JanStreffing approved these changes

@dsidoren dsidoren Awaiting requested review from dsidoren

Assignees

@dsidoren dsidoren

@JanStreffing JanStreffing

Labels
help wanted Extra attention is needed wait until approved
Projects
None yet
Milestone
FESOM 2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickscholz @JanStreffing @dsidoren @suvarchal