Improve error handling for open files for clock file and mesh file #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbeyer
force-pushed
the
improve_error_handling_file_open
branch
from
78d688c to
641c52d
Compare
|
What do you say, @JanStreffing ? Is it enough to check the |
Make a proper error message with the path where the file was expected and do proper mpi_abort.
sebastianbeyer
force-pushed
the
improve_error_handling_file_open
branch
from
641c52d to
ebe7709
Compare
|
I think checking for the presence of the rpart.out file should cover a majority of issues in the IFS-FESOM context when running on different machines ;) Maybe just checking for the presence of the right distXXX folder could already be enough. Also great to see that you check for the presence of the clock file. |
|
Hey, can we add this, @JanStreffing ? |
patrickscholz
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a proper error message with the path where the file was expected and do proper mpi_abort.