Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hash functions to finite elements #782

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Add a hash functions to finite elements #782

merged 10 commits into from
Mar 21, 2024

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Feb 2, 2024

Could be written into generated kernels then used to check that elements are the same.

garth-wells
garth-wells reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use std::hash?

https://en.cppreference.com/w/cpp/utility/hash

@mscroggs
Copy link
Member Author

mscroggs commented Feb 7, 2024

Could we use std::hash?

https://en.cppreference.com/w/cpp/utility/hash

That would probably be better

@mscroggs mscroggs marked this pull request as draft February 7, 2024 22:05
@mscroggs mscroggs marked this pull request as ready for review March 21, 2024 11:51
@mscroggs mscroggs enabled auto-merge March 21, 2024 11:54
@mscroggs mscroggs added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 0315c73 Mar 21, 2024
21 checks passed
@mscroggs mscroggs deleted the mscroggs/hash branch March 21, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garth-wells garth-wells garth-wells left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscroggs @garth-wells