Allow VectorElement to take a variant argument. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do this for |
garth-wells
reviewed
Apr 25, 2020
| @@ -263,6 +263,8 @@ def __init__(self, family, cell=None, degree=None, dim=None, | |||
| viewed as k-form), ignored if family is a FiniteElement | |||
| quad_scheme | |||
| The quadrature scheme (optional), ignored if family is a FiniteElement | |||
| variant | |||
There was a problem hiding this comment.
I think this needs a bit more explanation. I don't understand the docstring.
There was a problem hiding this comment.
This variant thing was first introduced to distinguish between GL, GLL, and equispaced Langrange elements without a profusion of names: Q, dQ, RTCE, RTCF, NCE, NCF type elements could be built from equispaced Lagrange as well as from spectral ingredients.
Later uses of this include RT and N1curl elements being available with different nodal basis, etc.
There was a problem hiding this comment.
For further reference, see this UFL issue and this UFL pull request.
garth-wells
pushed a commit
that referenced
this pull request
Jan 6, 2023
* add variant for MixedElement (#129) * Allow VectorElement to take a variant argument. (#17) Co-authored-by: Patrick Farrell <patrick@pefarrell.org> Co-authored-by: Pablo Brubeck <brubeck@protonmail.com> Co-authored-by: Patrick E. Farrell <patrick.farrell@maths.ox.ac.uk> Co-authored-by: Patrick Farrell <patrick@pefarrell.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.